public/linphone-android
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Parse friends in a coroutine scope, no need to do it on the Core's thread

Browse source
This commit is contained in:
Sylvain Berfini 2025-03-25 13:41:47 +01:00
parent d150027c24
commit 8dda38a925
1 changed files with 21 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

33
app/src/main/java/org/linphone/contacts/ContactLoader.kt
View file

@ -29,8 +29,14 @@ import androidx.annotation.WorkerThread
import androidx.loader.app.LoaderManager
import androidx.loader.content.CursorLoader
import androidx.loader.content.Loader
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.SupervisorJob
import kotlinx.coroutines.cancel
import kotlinx.coroutines.launch
import java.lang.Exception
import org.linphone.LinphoneApplication.Companion.coreContext
import org.linphone.core.Core
import org.linphone.core.Factory
import org.linphone.core.Friend
import org.linphone.core.FriendList
@ -63,6 +69,8 @@ class ContactLoader : LoaderManager.LoaderCallbacks<Cursor> {
private val friends = HashMap<String, Friend>()
private val scope = CoroutineScope(Dispatchers.IO + SupervisorJob())
@MainThread
override fun onCreateLoader(id: Int, args: Bundle?): Loader<Cursor> {
Log.i("$TAG Creating and starting cursor loader")
@ -107,26 +115,27 @@ class ContactLoader : LoaderManager.LoaderCallbacks<Cursor> {
}
Log.i("$TAG Load finished, found ${cursor.count} entries in cursor")
coreContext.postOnCoreThreadWhenAvailableForHeavyTask({
parseFriends(cursor)
}, "parse friends")
coreContext.postOnCoreThread {
val core = coreContext.core
val state = core.globalState
if (state == GlobalState.Shutdown || state == GlobalState.Off) {
Log.w("$TAG Core is being stopped or already destroyed, abort")
} else {
scope.launch {
parseFriends(core, cursor)
}
}
}
}
@MainThread
override fun onLoaderReset(loader: Loader<Cursor>) {
Log.i("$TAG Loader reset")
scope.cancel()
}
@WorkerThread
private fun parseFriends(cursor: Cursor) {
val core = coreContext.core
val state = core.globalState
if (state == GlobalState.Shutdown || state == GlobalState.Off) {
Log.w("$TAG Core is being stopped or already destroyed, abort")
return
}
private fun parseFriends(core: Core, cursor: Cursor) {
try {
val contactIdColumn = cursor.getColumnIndexOrThrow(ContactsContract.Data.CONTACT_ID)
val mimetypeColumn = cursor.getColumnIndexOrThrow(ContactsContract.Data.MIMETYPE)